From 4d5bebba07c5f974c53c9af488dd52a24c5d285a Mon Sep 17 00:00:00 2001 From: Grzegorz Russek Date: Thu, 26 Feb 2026 15:27:01 +0100 Subject: [PATCH] Small warning fix --- AmalgamationTool/DynamORM.Amalgamation.cs | 2 -- DynamORM/DynamicProcedureInvoker.cs | 38 +++++++++++------------ 2 files changed, 18 insertions(+), 22 deletions(-) diff --git a/AmalgamationTool/DynamORM.Amalgamation.cs b/AmalgamationTool/DynamORM.Amalgamation.cs index 7955999..e9ebcd5 100644 --- a/AmalgamationTool/DynamORM.Amalgamation.cs +++ b/AmalgamationTool/DynamORM.Amalgamation.cs @@ -5539,8 +5539,6 @@ namespace DynamORM Type listType = typeof(List<>).MakeGenericType(new Type[] { argType }); IList listInstance = (IList)Activator.CreateInstance(listType); - object defVal = listType.GetDefaultValue(); - using (IDataReader rdr = cmd.ExecuteReader()) using (IDataReader cache = rdr.CachedReader()) while (cache.Read()) diff --git a/DynamORM/DynamicProcedureInvoker.cs b/DynamORM/DynamicProcedureInvoker.cs index 14f0770..7758da2 100644 --- a/DynamORM/DynamicProcedureInvoker.cs +++ b/DynamORM/DynamicProcedureInvoker.cs @@ -51,11 +51,11 @@ namespace DynamORM /// public class ProcResult { [Column("outp")] public Guid Output { get; set; } } /// ProcResult res4 = db.Procedures.sp_Test_Scalar_In_Out<ProcResult>(inp: Guid.NewGuid(), out_outp: Guid.Empty) as ProcResult; /// As you can se, you can use mapper to do job for you. - public class DynamicProcedureInvoker : DynamicObject, IDisposable - { - private DynamicDatabase _db; - private List _prefixes; - private bool _isDisposed; + public class DynamicProcedureInvoker : DynamicObject, IDisposable + { + private DynamicDatabase _db; + private List _prefixes; + private bool _isDisposed; internal DynamicProcedureInvoker(DynamicDatabase db, List prefixes = null) { @@ -314,8 +314,6 @@ namespace DynamORM Type listType = typeof(List<>).MakeGenericType(new Type[] { argType }); IList listInstance = (IList)Activator.CreateInstance(listType); - object defVal = listType.GetDefaultValue(); - using (IDataReader rdr = cmd.ExecuteReader()) using (IDataReader cache = rdr.CachedReader()) while (cache.Read()) @@ -447,16 +445,16 @@ namespace DynamORM return true; } - /// Performs application-defined tasks associated with - /// freeing, releasing, or resetting unmanaged resources. - public void Dispose() - { - if (_isDisposed) - return; - - _isDisposed = true; - _db = null; - _prefixes = null; - } - } -} + /// Performs application-defined tasks associated with + /// freeing, releasing, or resetting unmanaged resources. + public void Dispose() + { + if (_isDisposed) + return; + + _isDisposed = true; + _db = null; + _prefixes = null; + } + } +}